Repository navigation
Conversation
Settings → Appearance → Window & Sidebar now has dark/light pickers for the workspace tab-group split. The existing terminal divider colors stay independent so uncustomized layouts keep #71717a/#868690.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe change adds separate dark and light settings for workspace tab-group split-divider colors. Appearance settings expose the controls and include them in search. The document appearance hook applies the selected color to the root CSS property for dark, light, and system themes. Strong-divider CSS colors now use mixes of the base divider colors. The change also adds defaults, color validation, and tests. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The divider settings preserve theme-specific defaults and update with configured colors and system appearance changes. No merge-blocking issue is established; the change is ready for normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new appearance options accept constrained colors and preserve existing defaults. No introduced security issue was identified, but saving, concurrent updates, and recovery behavior were not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 12a25c35-8382-4f04-85aa-e9eb862b14fb
📒 Files selected for processing (17)
src/main/codex-accounts/runtime-home-settings-test-fixtures.tssrc/main/codex-accounts/service-test-harness.tssrc/renderer/src/app-shell/use-document-appearance.tssrc/renderer/src/assets/main.csssrc/renderer/src/components/settings/AppearancePane.test.tsxsrc/renderer/src/components/settings/AppearancePane.tsxsrc/renderer/src/components/settings/AppearanceWindowSidebarSection.tsxsrc/renderer/src/components/settings/AppearanceWorkspaceSplitDividerSettings.tsxsrc/renderer/src/components/settings/appearance-search.tssrc/renderer/src/components/settings/setting-labels.tssrc/renderer/src/i18n/locales/en.jsonsrc/renderer/src/lib/tab-group-split-divider-appearance.test.tssrc/renderer/src/lib/tab-group-split-divider-appearance.tssrc/shared/constants.tssrc/shared/global-settings-types.tssrc/shared/tab-group-split-divider.test.tssrc/shared/tab-group-split-divider.ts
Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review.
Searching for a control-only term like "tab group" now mounts Window & Sidebar so the new pickers are discoverable. Fixes stablyai#14893 review.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/renderer/src/components/settings/terminal-search.test.ts (1)
240-246: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winScope the search assertion to the new entries.
The current assertion searches the entire Appearance catalog. It can pass because an unrelated entry matches
tab group, even if the new entries lose that keyword. Assert the query againstdarkEntryandlightEntryseparately.Proposed test update
- expect(matchesSettingsSearch('tab group', getAppearancePaneSearchEntries())).toBe(true) + expect(matchesSettingsSearch('tab group', darkEntry)).toBe(true) + expect(matchesSettingsSearch('tab group', lightEntry)).toBe(true)
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9883f586-2cab-4d3e-a9a2-d4f5d75739d7
📒 Files selected for processing (5)
src/renderer/src/components/settings/AppearancePane.test.tsxsrc/renderer/src/components/settings/AppearancePane.tsxsrc/renderer/src/components/settings/AppearanceWorkspaceSplitDividerSettings.tsxsrc/renderer/src/components/settings/appearance-search.tssrc/renderer/src/components/settings/terminal-search.test.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- src/renderer/src/components/settings/AppearancePane.tsx
- src/renderer/src/components/settings/AppearancePane.test.tsx
- src/renderer/src/components/settings/AppearanceWorkspaceSplitDividerSettings.tsx
Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 683bc75c-3051-468c-b9d8-6308086352f8
📒 Files selected for processing (13)
src/renderer/src/app-shell/use-document-appearance.test.tsxsrc/renderer/src/app-shell/use-document-appearance.tssrc/renderer/src/assets/main.csssrc/renderer/src/components/settings/AppearancePane.test.tsxsrc/renderer/src/components/settings/AppearancePane.tsxsrc/renderer/src/components/settings/AppearanceWindowSidebarSection.tsxsrc/renderer/src/components/settings/appearance-search.tssrc/renderer/src/components/settings/setting-labels.tssrc/renderer/src/components/settings/terminal-search.test.tssrc/renderer/src/i18n/locales/en.jsonsrc/renderer/src/lib/tab-group-split-divider-appearance.tssrc/shared/default-global-settings.tssrc/shared/global-settings-types.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/renderer/src/i18n/locales/en.json
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.
# Conflicts: # src/renderer/src/i18n/locales/en.json
|
| /* Brighter than terminal defaults so the always-visible line clears 3:1 on `--card`. */ | ||
| --tab-group-split-divider: #71717a; | ||
| --tab-group-split-divider-strong: #a1a1aa; | ||
| --tab-group-split-divider-strong: color-mix(in srgb, var(--tab-group-split-divider) 70%, #ffffff); |
There was a problem hiding this comment.
Extreme colors lose hover feedback In dark mode, a white divider mixed toward white has the same color on hover and drag. The light-mode mix toward black has the same problem for a black divider. Because the handle uses that mixed color for its hover and drag states, these valid choices lose the visual drag cue.
There was a problem hiding this comment.
Fixed in 05033640297641fa6da9d114ea14219f2f72e01d. Hover and drag now grow only the visible divider from 3px to 4px in both orientations, so light-mode black and dark-mode white retain an interaction cue. Chosen colors, existing mixes/defaults, centered positioning, the 6px hit area and pane layout are unchanged.
Actual Electron before/after coverage checks both orientations and six theme/color combinations through idle, hover, pointer drag, release and drag-without-hover: 60 paired color/geometry samples preserve every value except active thickness. Parent reran 96 focused tests, four freshly rebuilt hidden Electron tests, full pnpm tc, normal hooks and the unchanged review-delta quality gate; all pass.
|
Closing as superseded by #36578, which makes this color a public theme token ( |
ELI5
The gray column between a terminal tab and an editor/browser tab now has its own color pickers. Changing Dark Divider Color still only affects splits inside a terminal tab, which is what that setting always did.
What Changed
Settings → Appearance → Window & Sidebar now has Workspace Split Divider (Dark) and Workspace Split Divider (Light). They write
tabGroupSplitDividerColorDark/Lightonto--tab-group-split-divider. Hover/drag uses a stronger mix of that same color.The existing terminal divider pickers are unchanged. New keys default to today's tokens (
#71717adark,#868690light), so people who never customized a divider keep the current workspace line.Why
Dark Divider Color says it “controls the split divider line between panes,” but it only paints
.pane-dividerinside a terminal tab. The line people actually look at —.tab-group-split-resize-handlebetween workspace panes — was hardcoded. Reusing the terminal color would silently restyle every uncustomized workspace split (#71717a→#3f3f46). A sibling pair under Window & Sidebar keeps the two surfaces independent.Linked Issue
Fixes #14887
Visual Proof
Before: Dark Divider Color saved as
#171717. Split Terminal Right went near-black. The workspace column between a Claude/Grok terminal and a markdown editor stayed zinc (#71717a, sampled ~#76777c).After: Window & Sidebar exposes two workspace pickers. Changing the dark picker to
#171717persiststabGroupSplitDividerColorDarkand sets--tab-group-split-divideron the document root. The in-terminal divider is unaffected.I have local before captures from the #14887 investigation (settings picker at
#171717, workspace column still zinc). I could not upload binaries throughghfrom this environment; happy to drop them on the PR if maintainers want the files.Testing
Local gates (macOS, Node 26 / pnpm 10; repo wants Node 24):
pnpm lintpnpm typecheckpnpm buildpnpm test— 53,498 passed / 166 skipped / 3 failed in the full run. The three failures are unrelated environment flakes (macOS helper owner-loss PID file, relay grace timeout, Electron cookie-import spawn timeout). Two of those three passed when rerun in isolation; the helper-owner-loss case still flakes locally. Feature coverage: 30/30 (tab-group-split-divider, appearance apply, AppearancePane search + color persist).Reviewer steps:
#171717.workspace split dividerand forWindow & Sidebar.Not exercised live: Linux, Windows, SSH host. Those paths share the same renderer CSS variable and settings merge; no RPC, path, or shortcut change.
AI Disclosure
Implemented and reviewed with Grok 4.6 (xAI).
Review
ColorField/ settings merge. No new shortcuts, path separators, or Electron menu accelerators.setPropertyon the document root when settings or system theme change. Hover/drag stays CSScolor-mix.HEX_COLOR_RE; invalid values fall back to the shipped tokens. No new IPC, filesystem, or network.Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
#a1a1aa; it tracks the chosen base color.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)Author