Skip to content

feat(appearance): make workspace split divider color configurable - #14893

Closed
mmarabel wants to merge 7 commits into
stablyai:mainfrom
mmarabel:feat/tab-group-split-divider-color
Closed

mmarabel wants to merge 7 commits into
stablyai:mainfrom
mmarabel:feat/tab-group-split-divider-color

Conversation

@mmarabel

Copy link
Copy Markdown
Contributor

ELI5

The gray column between a terminal tab and an editor/browser tab now has its own color pickers. Changing Dark Divider Color still only affects splits inside a terminal tab, which is what that setting always did.

What Changed

Settings → Appearance → Window & Sidebar now has Workspace Split Divider (Dark) and Workspace Split Divider (Light). They write tabGroupSplitDividerColorDark / Light onto --tab-group-split-divider. Hover/drag uses a stronger mix of that same color.

The existing terminal divider pickers are unchanged. New keys default to today's tokens (#71717a dark, #868690 light), so people who never customized a divider keep the current workspace line.

Why

Dark Divider Color says it “controls the split divider line between panes,” but it only paints .pane-divider inside a terminal tab. The line people actually look at — .tab-group-split-resize-handle between workspace panes — was hardcoded. Reusing the terminal color would silently restyle every uncustomized workspace split (#71717a → #3f3f46). A sibling pair under Window & Sidebar keeps the two surfaces independent.

Linked Issue

Fixes #14887

Visual Proof

Before: Dark Divider Color saved as #171717. Split Terminal Right went near-black. The workspace column between a Claude/Grok terminal and a markdown editor stayed zinc (#71717a, sampled ~#76777c).

After: Window & Sidebar exposes two workspace pickers. Changing the dark picker to #171717 persists tabGroupSplitDividerColorDark and sets --tab-group-split-divider on the document root. The in-terminal divider is unaffected.

I have local before captures from the #14887 investigation (settings picker at #171717, workspace column still zinc). I could not upload binaries through gh from this environment; happy to drop them on the PR if maintainers want the files.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

Local gates (macOS, Node 26 / pnpm 10; repo wants Node 24):

  • pnpm lint
  • pnpm typecheck
  • pnpm build
  • pnpm test — 53,498 passed / 166 skipped / 3 failed in the full run. The three failures are unrelated environment flakes (macOS helper owner-loss PID file, relay grace timeout, Electron cookie-import spawn timeout). Two of those three passed when rerun in isolation; the helper-owner-loss case still flakes locally. Feature coverage: 30/30 (tab-group-split-divider, appearance apply, AppearancePane search + color persist).

Reviewer steps:

  1. Settings → Appearance → Window & Sidebar → set Workspace Split Divider (Dark) to #171717.
  2. Split a terminal tab next to an editor. The workspace column should go near-black.
  3. Use Split Terminal Right. The inner divider should still follow Dark Divider Color, not the new workspace picker.
  4. Repeat in light mode with the light picker.
  5. Search Settings for workspace split divider and for Window & Sidebar.

Not exercised live: Linux, Windows, SSH host. Those paths share the same renderer CSS variable and settings merge; no RPC, path, or shortcut change.

AI Disclosure

Implemented and reviewed with Grok 4.6 (xAI).

Review

  • Cross-platform: reuses existing ColorField / settings merge. No new shortcuts, path separators, or Electron menu accelerators.
  • SSH / remote / folder workspaces: appearance is renderer-only. Local, SSH, WSL, and folder workspaces use the same tab-group split handle. No wire, RPC, or stream change.
  • Agents / git providers: no agent, Git, or review-surface change.
  • Performance: one setProperty on the document root when settings or system theme change. Hover/drag stays CSS color-mix.
  • UI: placed under Window & Sidebar (workspace chrome), not Terminal theme, so the copy matches the surface. Search keywords include workspace/split/divider.
  • Security: hex colors validated with the existing HEX_COLOR_RE; invalid values fall back to the shipped tokens. No new IPC, filesystem, or network.

Agent skill upstream boundary

  • Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

  • Defaults stay the current contrast-safe tokens so existing layouts do not shift.
  • Hover/drag no longer uses a fixed #a1a1aa; it tracks the chosen base color.
  • Mobile uses the same CSS variable if it renders workspace splits; no mobile-specific API.

Checklist

  • This PR is small and focused
  • I explained what changed and why (including ELI5)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

Author

Settings → Appearance → Window & Sidebar now has dark/light pickers
for the workspace tab-group split. The existing terminal divider
colors stay independent so uncustomized layouts keep #71717a/#868690.
@mmarabel
mmarabel requested a review from brennanb2025 as a code owner August 16, 2026 13:51
@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 397e11ea-6311-44df-a351-2b73d83a16fe

📥 Commits

Reviewing files that changed from the base of the PR and between 0e89ca2 and 367d0e8.

📒 Files selected for processing (2)
  • src/renderer/src/app-shell/use-document-appearance.test.tsx
  • src/renderer/src/app-shell/use-document-appearance.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The change adds separate dark and light settings for workspace tab-group split-divider colors. Appearance settings expose the controls and include them in search. The document appearance hook applies the selected color to the root CSS property for dark, light, and system themes. Strong-divider CSS colors now use mixes of the base divider colors. The change also adds defaults, color validation, and tests.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 367d0

The divider settings preserve theme-specific defaults and update with configured colors and system appearance changes. No merge-blocking issue is established; the change is ready for normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 367d0

The new appearance options accept constrained colors and preserve existing defaults. No introduced security issue was identified, but saving, concurrent updates, and recovery behavior were not fully verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The introduced styling influence is document-scoped: a configurable color is written to one fixed property on the renderer document root. The system-theme event already scheduled runtime graph publication before this PR, so that publication reachability is not newly introduced.

Trust Boundaries and Controls

  • observed — Before the CSS write, string input is trimmed and accepted only as three or six hexadecimal digits with an optional leading #. Missing or invalid strings use fixed defaults, and accepted values are normalized with #. The property name is fixed, rather than setting-controlled.
  • observed — The new controls use the existing settings-update interface. Its wrapper passes updates through normalization and persistence, uses a publication fence, and catches failures. The controls submit only divider fields; they do not request runtime-environment or worktree-visibility changes.

Resilience and Maintainability Implications

  • observed — The existing graph scheduler coalesces scheduled requests and records requests arriving during an in-flight publication. Its finally block clears the in-flight flag and schedules recorded pending work. This preserves existing scheduling cleanup, but does not establish guaranteed retry after every publication failure.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 14 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: configurable workspace split-divider colors in the appearance settings.
Description check ✅ Passed The description follows the required template and covers the user impact, implementation, rationale, linked issue, testing, platform considerations, AI disclosure, and checklist. It also discloses tha…
Linked Issues check ✅ Passed The PR meets the coding requirements in Issue #14887. It adds separate tabGroupSplitDividerColorDark and tabGroupSplitDividerColorLight settings with defaults #71717a and #868690. It exposes b…
Out of Scope Changes check ✅ Passed The changed files support Issue #14887. They implement settings types and defaults, Appearance controls, search and localization entries, divider application, CSS styling, and automated tests. The sum…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 12a25c35-8382-4f04-85aa-e9eb862b14fb

📥 Commits

Reviewing files that changed from the base of the PR and between e4e54a1 and 0a014d3.

📒 Files selected for processing (17)
  • src/main/codex-accounts/runtime-home-settings-test-fixtures.ts
  • src/main/codex-accounts/service-test-harness.ts
  • src/renderer/src/app-shell/use-document-appearance.ts
  • src/renderer/src/assets/main.css
  • src/renderer/src/components/settings/AppearancePane.test.tsx
  • src/renderer/src/components/settings/AppearancePane.tsx
  • src/renderer/src/components/settings/AppearanceWindowSidebarSection.tsx
  • src/renderer/src/components/settings/AppearanceWorkspaceSplitDividerSettings.tsx
  • src/renderer/src/components/settings/appearance-search.ts
  • src/renderer/src/components/settings/setting-labels.ts
  • src/renderer/src/i18n/locales/en.json
  • src/renderer/src/lib/tab-group-split-divider-appearance.test.ts
  • src/renderer/src/lib/tab-group-split-divider-appearance.ts
  • src/shared/constants.ts
  • src/shared/global-settings-types.ts
  • src/shared/tab-group-split-divider.test.ts
  • src/shared/tab-group-split-divider.ts

Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review.

Searching for a control-only term like "tab group" now mounts Window
& Sidebar so the new pickers are discoverable. Fixes stablyai#14893 review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/renderer/src/components/settings/terminal-search.test.ts (1)

240-246: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Scope the search assertion to the new entries.

The current assertion searches the entire Appearance catalog. It can pass because an unrelated entry matches tab group, even if the new entries lose that keyword. Assert the query against darkEntry and lightEntry separately.

Proposed test update
-    expect(matchesSettingsSearch('tab group', getAppearancePaneSearchEntries())).toBe(true)
+    expect(matchesSettingsSearch('tab group', darkEntry)).toBe(true)
+    expect(matchesSettingsSearch('tab group', lightEntry)).toBe(true)

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9883f586-2cab-4d3e-a9a2-d4f5d75739d7

📥 Commits

Reviewing files that changed from the base of the PR and between 0a014d3 and 9fb7b6b.

📒 Files selected for processing (5)
  • src/renderer/src/components/settings/AppearancePane.test.tsx
  • src/renderer/src/components/settings/AppearancePane.tsx
  • src/renderer/src/components/settings/AppearanceWorkspaceSplitDividerSettings.tsx
  • src/renderer/src/components/settings/appearance-search.ts
  • src/renderer/src/components/settings/terminal-search.test.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • src/renderer/src/components/settings/AppearancePane.tsx
  • src/renderer/src/components/settings/AppearancePane.test.tsx
  • src/renderer/src/components/settings/AppearanceWorkspaceSplitDividerSettings.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 683bc75c-3051-468c-b9d8-6308086352f8

📥 Commits

Reviewing files that changed from the base of the PR and between 9fb7b6b and f4100c0.

📒 Files selected for processing (13)
  • src/renderer/src/app-shell/use-document-appearance.test.tsx
  • src/renderer/src/app-shell/use-document-appearance.ts
  • src/renderer/src/assets/main.css
  • src/renderer/src/components/settings/AppearancePane.test.tsx
  • src/renderer/src/components/settings/AppearancePane.tsx
  • src/renderer/src/components/settings/AppearanceWindowSidebarSection.tsx
  • src/renderer/src/components/settings/appearance-search.ts
  • src/renderer/src/components/settings/setting-labels.ts
  • src/renderer/src/components/settings/terminal-search.test.ts
  • src/renderer/src/i18n/locales/en.json
  • src/renderer/src/lib/tab-group-split-divider-appearance.ts
  • src/shared/default-global-settings.ts
  • src/shared/global-settings-types.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/i18n/locales/en.json

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

# Conflicts:
#	src/renderer/src/i18n/locales/en.json
@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Adds user-configurable colors for workspace pane dividers.

The PR appears safe to merge, with a non-blocking hover-feedback limitation for extreme divider colors.

Findings

  1. P2 Extreme colors lose hover feedback ▶

Summary

The PR adds independent dark and light workspace split-divider settings while retaining the existing divider colors as defaults. The latest changes separate divider-color application from document-theme application and read current settings on system-theme changes.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Workspace divider settings] --> B[Resolved dark or light color]
  C[Theme setting or system change] --> B
  B --> D[Document CSS variable]
  D --> E[Workspace split handle]
Loading

Reviews (2) · Last reviewed commit: "test(settings): cover system divider upd..."

/* Brighter than terminal defaults so the always-visible line clears 3:1 on `--card`. */
--tab-group-split-divider: #71717a;
--tab-group-split-divider-strong: #a1a1aa;
--tab-group-split-divider-strong: color-mix(in srgb, var(--tab-group-split-divider) 70%, #ffffff);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Extreme colors lose hover feedback In dark mode, a white divider mixed toward white has the same color on hover and drag. The light-mode mix toward black has the same problem for a black divider. Because the handle uses that mixed color for its hover and drag states, these valid choices lose the visual drag cue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 05033640297641fa6da9d114ea14219f2f72e01d. Hover and drag now grow only the visible divider from 3px to 4px in both orientations, so light-mode black and dark-mode white retain an interaction cue. Chosen colors, existing mixes/defaults, centered positioning, the 6px hit area and pane layout are unchanged.

Actual Electron before/after coverage checks both orientations and six theme/color combinations through idle, hover, pointer drag, release and drag-without-hover: 60 paired color/geometry samples preserve every value except active thickness. Parent reran 96 focused tests, four freshly rebuilt hidden Electron tests, full pnpm tc, normal hooks and the unchanged review-delta quality gate; all pass.

@nwparker

nwparker commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded by #36578, which makes this color a public theme token (--text-link / --split-divider) any app theme can set. Thank you for this PR, it shaped the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Make the workspace tab-group split divider color configurable

4 participants